Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all StackLayout with Grid or Horizontal-/VerticalStackLayout #468

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented May 4, 2024

Changes fix two things:

  1. Replace all StackLayouts that contain a CollectionView or ListView with a Grid for better performance
  2. Replace all StackLayouts with the strongly oriented versions: HorizontalStackLayout or VerticalStackLayout

I've excluded 1 or 2 places and they still now use a regular StackLayout because in the code-behind the orientation was changed at runtime depending on the device orientation which is a valid use-case.

Fixes #467

@davidbritch davidbritch added the do-not-merge Do not merge label May 10, 2024
@davidbritch
Copy link
Contributor

This one needs some thought. Will discuss offline with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All of the CollectionView samples need to be updated so the CV is inside a Grid not a StackLayout
2 participants